fix: disable sorting enums with implicit values

azat-io · Jul 28, 2023 · f4a0e25 · f4a0e25
1 parent dbfd97b
commit f4a0e25
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 110 deletions.
diff --git a/rules/sort-enums.ts b/rules/sort-enums.ts
@@ -71,7 +71,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     TSEnumDeclaration: node => {
       if (
         node.members.length > 1 &&
-        node.members.some(({ initializer }) => initializer)
+        node.members.every(({ initializer }) => initializer)
       ) {
         let options = complete(context.options.at(0), {
           type: SortType.alphabetical,

diff --git a/test/sort-enums.test.ts b/test/sort-enums.test.ts
@@ -129,7 +129,7 @@ describe(RULE_NAME, () => {
       })
     })
 
-    it(`${RULE_NAME}(${type}): sorts enum members without initializer`, () => {
+    it(`${RULE_NAME}(${type}): doesn't sorts enum members without initializer`, () => {
       ruleTester.run(RULE_NAME, rule, {
         valid: [
           {
@@ -148,39 +148,7 @@ describe(RULE_NAME, () => {
             ],
           },
         ],
-        invalid: [
-          {
-            code: dedent`
-              enum TokyoGodfathers {
-                Gin,
-                Miyuki,
-                Hana = 'Hana',
-              }
-            `,
-            output: dedent`
-              enum TokyoGodfathers {
-                Gin,
-                Hana = 'Hana',
-                Miyuki,
-              }
-            `,
-            options: [
-              {
-                type: SortType.alphabetical,
-                order: SortOrder.asc,
-              },
-            ],
-            errors: [
-              {
-                messageId: 'unexpectedEnumsOrder',
-                data: {
-                  left: 'Miyuki',
-                  right: 'Hana',
-                },
-              },
-            ],
-          },
-        ],
+        invalid: [],
       })
     })
 
@@ -429,7 +397,7 @@ describe(RULE_NAME, () => {
       })
     })
 
-    it(`${RULE_NAME}(${type}): sorts enum members without initializer`, () => {
+    it(`${RULE_NAME}(${type}): doesn't sorts enum members without initializer`, () => {
       ruleTester.run(RULE_NAME, rule, {
         valid: [
           {
@@ -448,39 +416,7 @@ describe(RULE_NAME, () => {
             ],
           },
         ],
-        invalid: [
-          {
-            code: dedent`
-              enum TokyoGodfathers {
-                Gin,
-                Miyuki,
-                Hana = 'Hana',
-              }
-            `,
-            output: dedent`
-              enum TokyoGodfathers {
-                Gin,
-                Hana = 'Hana',
-                Miyuki,
-              }
-            `,
-            options: [
-              {
-                type: SortType.natural,
-                order: SortOrder.asc,
-              },
-            ],
-            errors: [
-              {
-                messageId: 'unexpectedEnumsOrder',
-                data: {
-                  left: 'Miyuki',
-                  right: 'Hana',
-                },
-              },
-            ],
-          },
-        ],
+        invalid: [],
       })
     })
 
@@ -736,7 +672,7 @@ describe(RULE_NAME, () => {
       })
     })
 
-    it(`${RULE_NAME}(${type}): sorts enum members without initializer`, () => {
+    it(`${RULE_NAME}(${type}): doesn't sorts enum members without initializer`, () => {
       ruleTester.run(RULE_NAME, rule, {
         valid: [
           {
@@ -755,46 +691,7 @@ describe(RULE_NAME, () => {
             ],
           },
         ],
-        invalid: [
-          {
-            code: dedent`
-              enum TokyoGodfathers {
-                Gin,
-                Miyuki,
-                Hana = 'Hana',
-              }
-            `,
-            output: dedent`
-              enum TokyoGodfathers {
-                Hana = 'Hana',
-                Miyuki,
-                Gin,
-              }
-            `,
-            options: [
-              {
-                type: SortType['line-length'],
-                order: SortOrder.desc,
-              },
-            ],
-            errors: [
-              {
-                messageId: 'unexpectedEnumsOrder',
-                data: {
-                  left: 'Gin',
-                  right: 'Miyuki',
-                },
-              },
-              {
-                messageId: 'unexpectedEnumsOrder',
-                data: {
-                  left: 'Miyuki',
-                  right: 'Hana',
-                },
-              },
-            ],
-          },
-        ],
+        invalid: [],
       })
     })