fix: detect dependencies in template literals

azat-io · Sep 6, 2024 · 4e0e6d8 · 4e0e6d8
1 parent f81f58b
commit 4e0e6d8
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 0 deletions.
diff --git a/rules/sort-classes.ts b/rules/sort-classes.ts
@@ -343,6 +343,10 @@ export default createEslintRule<SortClassesOptions, MESSAGE_ID>({
             if ('properties' in nodeValue) {
               nodeValue.properties.forEach(traverseNode)
             }
+
+            if ('expressions' in nodeValue) {
+              nodeValue.expressions.forEach(traverseNode)
+            }
           }
 
           let traverseNode = (nodeValue: TSESTree.Node[] | TSESTree.Node) => {

diff --git a/test/sort-classes.test.ts b/test/sort-classes.test.ts
@@ -3448,6 +3448,48 @@ describe(ruleName, () => {
         },
       )
 
+      ruleTester.run(
+        `${ruleName}(${type}) detects dependencies in template literal expressions`,
+        rule,
+        {
+          valid: [
+            {
+              code: dedent`
+               class Class {
+                b = 1
+                a = \`\${this.b}\`
+                static b = 1
+                static a = \`\${this.b}\`
+               }
+              `,
+              options: [
+                {
+                  ...options,
+                  groups: ['property'],
+                },
+              ],
+            },
+            {
+              code: dedent`
+               class Class {
+                b = 1
+                a = \`\${this.b}\`
+                static b = 1
+                static a = \`\${Class.b}\`
+               }
+              `,
+              options: [
+                {
+                  ...options,
+                  groups: ['property'],
+                },
+              ],
+            },
+          ],
+          invalid: [],
+        },
+      )
+
       ruleTester.run(
         `${ruleName}(${type}) separates static from non-static dependencies`,
         rule,