From 50d1b9470cf5dcc2ea3fc1034b990a63453558e4 Mon Sep 17 00:00:00 2001
From: Refael Ackermann <refack@gmail.com>
Date: Sat, 19 Aug 2017 17:57:36 -0400
Subject: [PATCH] test: improve assertion fail messages

PR-URL: https://github.com/nodejs/node/pull/14949
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/parallel/test-stream-inheritance.js | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/test/parallel/test-stream-inheritance.js b/test/parallel/test-stream-inheritance.js
index 8ca7ae1f1e..2d9a1e83ef 100644
--- a/test/parallel/test-stream-inheritance.js
+++ b/test/parallel/test-stream-inheritance.js
@@ -33,8 +33,14 @@ assert.ok(!(undefined instanceof Writable));
 
 // Simple inheritance check for `Writable` works fine in a subclass constructor.
 function CustomWritable() {
-  assert.ok(this instanceof Writable, 'inherits from Writable');
-  assert.ok(this instanceof CustomWritable, 'inherits from CustomWritable');
+  assert.ok(
+    this instanceof CustomWritable,
+    `${this} does not inherit from CustomWritable`
+  );
+  assert.ok(
+    this instanceof Writable,
+    `${this} does not inherit from Writable`
+  );
 }
 
 Object.setPrototypeOf(CustomWritable, Writable);
@@ -42,8 +48,11 @@ Object.setPrototypeOf(CustomWritable.prototype, Writable.prototype);
 
 new CustomWritable();
 
-assert.throws(CustomWritable,
-              common.expectsError({
-                code: 'ERR_ASSERTION',
-                message: /^inherits from Writable$/
-              }));
+common.expectsError(
+  CustomWritable,
+  {
+    code: 'ERR_ASSERTION',
+    type: assert.AssertionError,
+    message: 'undefined does not inherit from CustomWritable'
+  }
+);