Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Store does not implement the certmagic Storage interface #2

Open
APoolio opened this issue May 5, 2023 · 2 comments
Open

S3Store does not implement the certmagic Storage interface #2

APoolio opened this issue May 5, 2023 · 2 comments

Comments

@APoolio
Copy link

APoolio commented May 5, 2023

Was wanting to utilize the s3store package to handle the storage for certmagic but noticed the S3Store does not match the certmagic Storage interface

@APoolio
Copy link
Author

APoolio commented May 5, 2023

// Unlock releases the lock for name.
func (s *S3Store) Unlock(ctx context.Context, key string) error {
	return s.deleteLockFile(s.lockFileName(key))
}

@APoolio
Copy link
Author

APoolio commented May 9, 2023

It does appear to also be all methods in the Storage interface take in a context so it isn't just the Unlock method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant