plumbing: server, remove package in favor of transport #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes packp types follow the git protocol and simplifies the implementation of `Encode` and `Decode` methods to be consistent with the rest of the types. Reference: https://git-scm.com/docs/gitprotocol-pack
This type is used to represent HTTP smart protocol service payload request and response.
4 tasks
This change redefines the transport package to be more modular and extensible. It redefines the `transport.Transport`, `transport.Session`, and `transport.Commander` and `transport.Command` interfaces. It also introduces a new `transport.Connection` that abstracts the logic of sending and receiving git data to and from a server. There are 2 main transports. The pack transport which is a full-duplex command based transport that uses `transport.PackSession`. And the other is the HTTP transport which is a half-duplex transport that uses `transport.HTTPSession`. All of file, git, and ssh transports use the pack transport. The rest of the abstractions are defined in `transport.NegotiatePack`, `transport.FetchPack`, `transport.UploadPack`, `transport.SendPack`, and `tansport.ReceivePack`. All of these static functions are used by the `transport.Connection` to send and receive data to and from a `storage.Storer` interface type. Reference: https://gist.github.com/aymanbagabas/1b5ccc265ee62dd574c62d378b4b57bb
aymanbagabas
force-pushed
the
v6-transport-transport
branch
from
0319a50 to
130063f
Compare
We no longer need a separate package for the server protocol, as it is now implemented in the transport package.
It makes more sense to have this living in the transport package, as it is related to the transport layer.
aymanbagabas
force-pushed
the
v6-transport-server
branch
from
5db3738 to
dfb0c57
Compare
aymanbagabas
force-pushed
the
v6-transport-transport
branch
7 times, most recently
from
2d37d80 to
95f4718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need a separate package for the server protocol, as it is now implemented in the transport package.