plumbing: transport, refactor and define transport operations #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aymanbagabas
force-pushed
the
v6-transport-transport
branch
from
0319a50 to
130063f
Compare
aymanbagabas
force-pushed
the
v6-transport-packp
branch
from
0e7a3c8 to
3248748
Compare
aymanbagabas
force-pushed
the
v6-transport-transport
branch
from
130063f to
3bcf9fc
Compare
aymanbagabas
force-pushed
the
v6-transport-packp
branch
from
3248748 to
3e2ba6a
Compare
aymanbagabas
force-pushed
the
v6-transport-transport
branch
3 times, most recently
from
15e2048 to
0f3b3ef
Compare
aymanbagabas
force-pushed
the
v6-transport-packp
branch
from
3e2ba6a to
fecc06e
Compare
aymanbagabas
force-pushed
the
v6-transport-transport
branch
from
0f3b3ef to
f077b31
Compare
aymanbagabas
force-pushed
the
v6-transport-packp
branch
from
2b293b9 to
9986c5c
Compare
refactor transport: plumbing: packp, refactor types (1/5)
aymanbagabas
force-pushed
the
v6-transport-transport
branch
from
f077b31 to
2d37d80
Compare
This change redefines the transport package to be more modular and extensible. It redefines the `transport.Transport`, `transport.Session`, and `transport.Commander` and `transport.Command` interfaces. It also introduces a new `transport.Connection` that abstracts the logic of sending and receiving git data to and from a server. There are 2 main transports. The pack transport which is a full-duplex command based transport that uses `transport.PackSession`. And the other is the HTTP transport which is a half-duplex transport that uses `transport.HTTPSession`. All of file, git, and ssh transports use the pack transport. The rest of the abstractions are defined in `transport.NegotiatePack`, `transport.FetchPack`, `transport.UploadPack`, `transport.SendPack`, and `tansport.ReceivePack`. All of these static functions are used by the `transport.Connection` to send and receive data to and from a `storage.Storer` interface type. Reference: https://gist.github.com/aymanbagabas/1b5ccc265ee62dd574c62d378b4b57bb
We no longer need a separate package for the server protocol, as it is now implemented in the transport package.
It makes more sense to have this living in the transport package, as it is related to the transport layer.
aymanbagabas
force-pushed
the
v6-transport-transport
branch
from
2d37d80 to
95f4718
Compare
Co-authored-by: Paulo Gomes <[email protected]> Update remote.go Co-authored-by: Paulo Gomes <[email protected]>
aymanbagabas
force-pushed
the
v6-transport-transport
branch
from
a639d95 to
2279b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change redefines the transport package to be more modular and extensible. It redefines the
transport.Transport,transport.Session, andtransport.Commanderandtransport.Commandinterfaces. It also introduces a newtransport.Connectionthat abstracts the logic of sending and receiving git data to and from a server.There are 2 main transports. The pack transport which is a full-duplex command based transport that uses
transport.PackSession. And the other is the HTTP transport which is a half-duplex transport that usestransport.HTTPSession. All of file, git, and ssh transports use the pack transport.The rest of the abstractions are defined in
transport.NegotiatePack,transport.FetchPack,transport.UploadPack,transport.SendPack, andtansport.ReceivePack. All of these static functions are used by thetransport.Connectionto send and receive data to and from astorage.Storerinterface type.Reference: https://gist.github.com/aymanbagabas/1b5ccc265ee62dd574c62d378b4b57bb