use native lsp inline virtual text on neovim nightly

[ClSlaid]

Feature description

NeoVim nightly just got native inlay virtual text support. 0.10 branch now could get rid of lsp-inlayhints.nvim.

showcase with rust

Additional information

No response

[fecet]

Can we also get rid of lsp_signature, it's the reason of many delay of nvim-cmp. However most python lsp (I primarily use python) doesn't support inlay hint, maybe change to pylyzer?

[CharlesChiuGit]

Upvote for removing lsp-inlayhints.nvim and lsp_signature in 0.10 branch. (Personally I don't use lsp signature's functionality)
I'm not sure about pylyzer tho, never tried it before.

[ayamir]

Can we also get rid of lsp_signature, it's the reason of many delay of nvim-cmp. However most python lsp (I primarily use python) doesn't support inlay hint, maybe change to pylyzer?

IMO inlay hint isn't so important to make us replace pylsp with pylyzer which isn't tried and tested very well.

[fecet]

Personally, I would like to give pylyzer a try because I often experience delays with nvim-cmp and gd when browsing large files, perhaps I will create a PR for this.
However, is there any way to test the differences between LSPs to check if Pylyzer is better (or worse)?

Edit: pylyzer doesn't support local package so it may not avaliable now... But I just found https://github.com/jbradaric/pyright-inlay-hints, maybe we can try this fork

[Jint-lzxy]

Can we also get rid of lsp_signature, it's the reason of many delay of nvim-cmp.

IMHO We should keep lsp_signature b/c we need this for languages that require information related to function signatures (e.g., languages that support function overloading like C++). This delay is actually an upstream issue.

However, is there any way to test the differences between LSPs to check if Pylyzer is better (or worse)?

Check if it supports maximum server capabilities (subsection TextDocumentClientCapabilities).

[vollowx]

Maybe have a look at this as a ref.

[CharlesChiuGit]

Maybe have a look at this as a ref.

I think it's not a bad idea to remove lsp_signature if u got free time and looking for max nvim startup speed; however, then we will need to config each language servers, which would be quite a hustle for neovim new comers to config their own language servers.

To avoid issue overflow, I think it's better to keep the nvim config more on the sensible side.

[CharlesChiuGit]

This feature is already implement in https://github.com/ayamir/nvimdots/tree/0.10 branch, closing this issue if no further discussion.

[fecet]

This feature is already implement in https://github.com/ayamir/nvimdots/tree/0.10 branch

This is implement by https://github.com/lvimuser/lsp-inlayhints.nvim, is there any reasonn to use it over native inlay support?

[CharlesChiuGit]

This is implement by lvimuser/lsp-inlayhints.nvim, is there any reason to use it over native inlay support?

Sorry, missed that. reopen the issue.

[vollowx]

Note that the native API has recently changed at this commit

[jczhang02]

pylance is a choice? I have found some open source implementations.

[CharlesChiuGit]

pylance is a choice? I have found some open source implementations.

I thought it wasn't legal to use pylance outside of vscode?

[fecet]

mason-org/mason-registry@a25ffdb

[jczhang02]

pylance is a choice? I have found some open source implementations.

I thought it wasn't legal to use pylance outside of vscode?

Not legal, but can be a choice.

[jczhang02]

Perhaps we can recommend the development of the 0.10.0 branch. I would like to know who is willing to use version 0.10.0?

[CharlesChiuGit]

hmmm, i'm strongly hesitate about this...
@Jint-lzxy @ayamir
how to u think?

[CharlesChiuGit]

mason-org/mason-registry@a25ffdb

it is being merged yet?

[ayamir]

have not seen pylance in https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md.

[ayamir]

The original issue is addressed at 2dfc8ea and IMO this issue can be closed.
Maybe we can open a new issue for the discussion of python lsp or just stay as it is.

[Jint-lzxy]

how do u think?

Sorry I've been hit w/ a flu recently and might need to rest for a few more days 😢 But I'm w/ @ayamir on this, we could open a new issue for discussion. AFAIK even tho some LSs designed for vscode do offer some exclusive handy features, they usually come w/ licenses that strictly limit usage outside of vscode. IANAL but I've seen some issues caused by these licenses. The license is roughly phrased as follows:

You may use the software solely with
< list of VS products >
And you may not share, or publish the software to a third party without prior consent…

---

btw, happy lunar new year! 🎆 (finally made it home lol)

[CharlesChiuGit]

@Jint-lzxy sad to hear that, hope u get well soon!

agree on opening a new issue about python lsp.

happy lunar new year to everyone too! 🎊

[ayamir]

@Jint-lzxy Wishing you a speedy recovery and good health! And happy lunar new year! 🎉

[vollowx]

Happy new lunar year 🎉