Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvim-treesitter intergration requires neovim 0.8 #568

Closed
Tracked by #627
mirroez opened this issue Mar 13, 2023 · 10 comments
Closed
Tracked by #627

nvim-treesitter intergration requires neovim 0.8 #568

mirroez opened this issue Mar 13, 2023 · 10 comments
Labels
platform:legacy Compatibility issues caused by low OS version treesitter Treesitter related issues wontfix This will not be worked on

Comments

@mirroez
Copy link

mirroez commented Mar 13, 2023

Feature description

你好,nvimdots 的配置非常好用。但是我由于远端服务器原因只能使用neovim 0.72 ,clone 0.7库并更新后 报出提示nvim-treesitter intergration requires neovim 0.8,我该在哪个文件中指定nvim-treesitter 支持0.72的旧版本? 下面是一些打开lua文件时报出的错误,我该如何修复他们?

Additional information

Error executing vim.schedule lua callback: ...pack/packer/start/mason.nvim/lua/mason-registry/init.lua:78: Cannot find package "stylua".
stack traceback:
[C]: in function 'error'
...pack/packer/start/mason.nvim/lua/mason-registry/init.lua:78: in function 'get_package'
...on-tool-installer.nvim/lua/mason-tool-installer/init.lua:111: in function ''
vim/_editor.lua: in function ''
vim/_editor.lua: in function <vim/_editor.lua:0>

Error detected while processing InsertEnter Autocommands for "*":
E5108: Error executing lua ...vim/site/pack/packer/opt/packer.nvim/lua/packer/load.lua:179: Vim(echomsg):E114: Missing quote: "Error in packer_compiled: ...vim/site/pa
ck/packer/opt/packer.nvim/lua/packer/load.lua:168: Vim(lua):E5108: Error executing lua ...te/pack/packer/start/filetype.nvim/lua/filetype/init.lua:8: Vim(append):Error
executing lua callback: ...er/opt/nvim-treesitter/lua/nvim-treesitter/highlight.lua:28: attempt to call field 'stop' (a nil value)
stack traceback:
[C]: in function 'cmd'
...vim/site/pack/packer/opt/packer.nvim/lua/packer/load.lua:179: in function <...vim/site/pack/packer/opt/packer.nvim/lua/packer/load.lua:175>
[string ":lua"]:1: in main chunk
Press ENTER or type command to continue
Error detected while processing function 4[71]..matchup#delim#get_current[1]..58_get_delim_multi[3]..matchup#ts_engine#get_delim[3]..50_forward:
line 1:
E5108: Error executing lua ...vim-matchup/lua/treesitter-matchup/third-party/utils.lua:116: attempt to call field 'get_node_range' (a nil value)
stack traceback:
...vim-matchup/lua/treesitter-matchup/third-party/utils.lua:116: in function 'is_in_node_range'
...cker/opt/vim-matchup/lua/treesitter-matchup/internal.lua:222: in function 'get_delim'

@mirroez mirroez added the enhancement New feature or request label Mar 13, 2023
@ayamir
Copy link
Owner

ayamir commented Mar 14, 2023

You can cd to the directory of nvim-treesitter then checkout to 0.7.2 tag.
https://github.com/nvim-treesitter/nvim-treesitter/tree/v0.7.2

cd ~/.local/share/nvim/site/packer/opt/nvim-treesitter/
git fetch --all --tags
git checkout tags/0.7.2

@Jint-lzxy Jint-lzxy added platform:legacy Compatibility issues caused by low OS version treesitter Treesitter related issues usage User-specific issues and removed enhancement New feature or request labels Mar 14, 2023
@mirroez
Copy link
Author

mirroez commented Mar 14, 2023

You can cd to the directory of nvim-treesitter then checkout to 0.7.2 tag. https://github.com/nvim-treesitter/nvim-treesitter/tree/v0.7.2

cd ~/.local/share/nvim/site/packer/opt/nvim-treesitter/
git fetch --all --tags
git checkout tags/0.7.2

十分感谢,这个问题解决了,但是还有个mason相关的问题:
当安装完插件重新进入nvim时会报错
image
Error executing vim.schedule lua callback: ...pack/packer/start/mason.nvim/lua/mason-registry/init.lua:78: Cannot find package "stylua".
stack traceback: [C]: in function 'error' ...pack/packer/start/mason.nvim/lua/mason-registry/init.lua:78: in function 'get_package' ...on-tool-installer.nvim/lua/mason-tool-installer/init.lua:111: in function '' vim/_editor.lua: in function ''

我不能确定是什么原因引起的这个问题

@aarnphm
Copy link
Collaborator

aarnphm commented Mar 14, 2023

can also set the version from lazy for this nvim-treesitter

plugins["nvim-treesitter/nvim-treesitter"] = {
  version = "0.7.2"
}

@ayamir
Copy link
Owner

ayamir commented Mar 15, 2023

You can comment this line to cancel the installation of stylua if you don't write lua file.


Or execute MasonInstall stylua then show us the log.

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Apr 14, 2023

@Jint-lzxy @ayamir I think we better drop support for 0.7. We didn't have a lock file at that time, which will make it almost impossible to maintaining it. I'm overwhelmed by errors when I checkout to branch 0.7.

@mirroez sorry for that, but I think u need to fix those error yourself.

@aarnphm
Copy link
Collaborator

aarnphm commented Apr 14, 2023

I think we better drop support for 0.7. We didn't have a lock file at that time, which will it almost impossible to maintaining it. I'm overwhelmed by errors when I checkout to branch 0.7.

Do you know what the timeline for support on different neovim version from the neovim team? If they don't have specific EOL support then we should just drop it.

imho neovim 0.8 should have been neovim 1.0, since the treesitter integration is relatively big.

@CharlesChiuGit
Copy link
Collaborator

I think we better drop support for 0.7. We didn't have a lock file at that time, which will it almost impossible to maintaining it. I'm overwhelmed by errors when I checkout to branch 0.7.

Do you know what the timeline for support on different neovim version from the neovim team? If they don't have specific EOL support then we should just drop it.

imho neovim 0.8 should have been neovim 1.0, since the treesitter integration is relatively big.

Maybe the time of each tags could be taken as a reference?
圖片

@ayamir
Copy link
Owner

ayamir commented Apr 17, 2023

@Jint-lzxy @ayamir I think we better drop support for 0.7. We didn't have a lock file at that time, which will make it almost impossible to maintaining it. I'm overwhelmed by errors when I checkout to branch 0.7.

@mirroez sorry for that, but I think u need to fix those error yourself.

Agree.

@Jint-lzxy
Copy link
Collaborator

Agree. I will open a PR to deprecate the 0.7 branch later. Specifically:

  • When the install script detects the version of nvim is less than or equal to 0.7, it will call _abort and prompt the user to update their nvim build;
  • The issue templates will mark nvim <= 0.7 as deprecated, and users who choose this branch will be rejected from submitting their issues (or closed directly).

@Jint-lzxy
Copy link
Collaborator

Closing as #686 is merged. This is a wontfix.

@Jint-lzxy Jint-lzxy closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2023
@Jint-lzxy Jint-lzxy added wontfix This will not be worked on and removed usage User-specific issues labels Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:legacy Compatibility issues caused by low OS version treesitter Treesitter related issues wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants