Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions (Thoughts) regarding recent changes #1213

Closed
3 tasks done
Jint-lzxy opened this issue Apr 2, 2024 · 4 comments · Fixed by #1215
Closed
3 tasks done

Questions (Thoughts) regarding recent changes #1213

Jint-lzxy opened this issue Apr 2, 2024 · 4 comments · Fixed by #1215
Labels
complexity:low Low-risk, unlikely to cause distant/indirect damage enhancement New feature or request packaging Lazy.nvim or mason.nvim related issues

Comments

@Jint-lzxy
Copy link
Collaborator

Version confirmation

  • Confirm

Following prerequisites

  • Confirm

Not a user config issue

  • Confirm

Neovim version

NVIM v0.9.5

Operating system/version

macOS 14.4.1 (23E224)

Terminal name/version

kitty 0.33.1

$TERM environment variable

kitty

Branch info

main (Default/Latest)

Fetch Preferences

SSH (use_ssh = true)

How to reproduce the issue

Sorry for not being active for a long time lol things got pretty hectic recently. I've been trying to catch up with all the changes here over the past couple of days (though not completely there yet), but I've got some questions and thoughts:

  1. I'm curious why sindrets/diffview.nvim got removed? I checked Clean project plugins #1196 and refactor(plugins): iterate plugins #1198 but couldn't find any useful info (or maybe I just missed something in my speedy scroll lmao, my bad). Initially, I thought maybe there's a better alternative, but it doesn't seem like 61c817f introduced changes for that, right? I also thought about vim-fugitive (heavy user here lmao), but maybe that's not as straightforward compared to diffview.nvim?

  2. Is there a slicker way to write _G._buf_vtext introduced in ccd5eda? AFAIK there's vim.region() (or in nightly, vim.getregion()), which intuitively fetches content from the corresponding region without the need for the intermediate step (using registers). Plus, using registers might make it tricky for neovim to distinguish some control characters (check :h copy-move).

  3. Why did we remove gelguy/wilder.nvim? It has some features that cmp-cmdline lacks (like Man.lua completion) and has been using APIs that have been around for some time, so it's unlikely to suddenly stop working in recent neovim releases. Personally, I feel like just because a plugin isn't actively maintained doesn't mean it's unusable, especially when it offers some irreplaceable and non-bloated functionality (though yeah, I might be a bit biased towards wilder.nvim, sorry about that).

  4. Maybe we could think about providing a "silent install" option? I briefly mentioned my thoughts in Automatic or silent installation #1185 (comment).

  5. It seems like we've introduced (official?) support for nightly builds in 9a15365? I'm wondering because nightly tends to have "some sort of" changes frequently, so supporting it might come with a bunch of potential small issues. And since neovim is still mostly backward compatible, installing the stable-version config for nightly builds doesn't appear to pose significant issues.

Expected behavior

1/3. Thinking of reintroducing sindrets/diffview.nvim (along with gelguy/wilder.nvim).
2. Rewrite _G._buf_vtext using vim.region().
4. Adding a "silent install" option.
5. Maybe we can give a heads up to nightly users that corresponding configs (e.g., branch 0.10) are available (instead of just installing the nightly-version config), but since they're not officially supported, suggesting they try fixing issues themselves or stick to stable versions.

Actual behavior

No response

Additional information

No response

@Jint-lzxy Jint-lzxy added enhancement New feature or request complexity:low Low-risk, unlikely to cause distant/indirect damage packaging Lazy.nvim or mason.nvim related issues labels Apr 2, 2024
@ayamir
Copy link
Owner

ayamir commented Apr 2, 2024

Glad to see you are back again!
1/3. Some plugins-related issues are discussed in #1196. Overall changes were basically our personally opinion's intersection. Of course, your questions are also reasonable. (personally I prefer wilder.nvim, want to remove vim-fugitive and be neutral about diffview.nvim.)
2. my bad, maybe using vim.region() is a better choice.
4. slice install seems can't complete all of install tasks like installation of lsps, treesitters, and other plugins build task. At least that's what I tried before, it's also one part of reason of the termination of #1080.
5. 0.10 branch is also usable but maybe have some little bugs. Adding some side notes in readme for users may help.

@CharlesChiuGit
Copy link
Collaborator

Also can we add smartyank back? At first, I think we have some native nvim support of remote yanking/pasting in 0.10, but it doesn't seem like the case.

@ayamir
Copy link
Owner

ayamir commented Apr 22, 2024

Also can we add smartyank back? At first, I think we have some native nvim support of remote yanking/pasting in 0.10, but it doesn't seem like the case.

The reason why I remove smartyank is that someday I suddenly found its repo and the author ibhagwan are 404 not found. Seems it has been recovered normally, I'd glad to add it back.
EDITED: 188b626

@CharlesChiuGit
Copy link
Collaborator

nice! tks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:low Low-risk, unlikely to cause distant/indirect damage enhancement New feature or request packaging Lazy.nvim or mason.nvim related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants