Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support any unsigned numbers (uint/ushort/ulong etc.) #235

Closed
Darkar25 opened this issue Dec 26, 2021 · 2 comments
Closed

Does not support any unsigned numbers (uint/ushort/ulong etc.) #235

Darkar25 opened this issue Dec 26, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@Darkar25
Copy link

Hi! Thanks for reporting this bug!

Please fill in the relevant information from this template so that we can help you best.

Smart.Format version: 2.7.1

Framework version: (e.g. net5.0) .NET Core 3.1

  • Please provide a working source code example to reproduce the bug {Id:cond:=1234?yes|no} P.S.Id is unsigned number type
  • What is the current result? "=1234?yes", no matter if Id is 1234 or not
  • What is the expected result? if Id is 1234 then "yes", otherwise "no"
  • Please post full exception details if applicable (message, stacktrace, inner exceptions)
  • Did you find a workaround? yes, cast your number into signed one...
  • Is there a version in which it worked? nah
  • Can you help us by writing an unit test? nah, sorry

I think the source of this bug is incorrect type check inside formatters...there was already this type of issue (#108), in PluralLocalization formatter...it appears to be fixed in that particular formatter, but not in others...for example Conditional formatter

@axunonb axunonb self-assigned this Dec 26, 2021
@axunonb axunonb added the Bug label Dec 26, 2021
@axunonb axunonb added this to the version/v3 milestone Dec 26, 2021
@axunonb axunonb changed the title Does not support any unsigned numbers (uint/ubyte/ulong etc.) Does not support any unsigned numbers (uint/ushort/ulong etc.) Dec 26, 2021
@axunonb
Copy link
Member

axunonb commented Dec 26, 2021

Closed by PR #236

@axunonb axunonb closed this as completed Dec 26, 2021
@Darkar25
Copy link
Author

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants