Skip to content

fix test_rm_lora rmv skip#3669

Merged
NanoCode012 merged 4 commits into
axolotl-ai-cloud:mainfrom
ved1beta:test-rwd
May 22, 2026
Merged

fix test_rm_lora rmv skip#3669
NanoCode012 merged 4 commits into
axolotl-ai-cloud:mainfrom
ved1beta:test-rwd

Conversation

@ved1beta

@ved1beta ved1beta commented May 20, 2026

Copy link
Copy Markdown
Member

Description

fix test_rm_lora rmv skip

Summary by CodeRabbit

  • Tests
    • Enabled end-to-end test for reward model functionality, expanding test coverage and validation.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e3519000-0d5d-433b-849c-bc3f17177ba5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR enables the previously skipped end-to-end reward model LoRA test (test_rm_lora) by removing the pytest.mark.skip decorator. The now-unused pytest import is removed to clean up the module.

Changes

Test Enablement

Layer / File(s) Summary
Enable LoRA reward model test
tests/e2e/test_reward_model_smollm2.py
The pytest.mark.skip(...) decorator is removed from test_rm_lora to allow the test to run. The unused pytest import is removed since the skip decorator was the only usage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix test_rm_lora rmv skip' directly describes the main change: removing the skip decorator from the test_rm_lora test so it will execute.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@NanoCode012 NanoCode012 merged commit 1d68aca into axolotl-ai-cloud:main May 22, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants