Skip to content

fix modal call with explicit module flag for future deprecation#3668

Merged
winglian merged 1 commit into
mainfrom
modal-run-module-deprecation
May 28, 2026
Merged

fix modal call with explicit module flag for future deprecation#3668
winglian merged 1 commit into
mainfrom
modal-run-module-deprecation

Conversation

@winglian

@winglian winglian commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD pipeline test execution commands to improve workflow efficiency.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 81fa7e71-66da-4a15-b3f6-0b516a0be240

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Modal command invocations across GitHub Actions test workflows are updated to explicitly pass module names using the -m flag. The nightly workflow's e2e and multigpu test jobs are updated, followed by the main test workflow's e2e and cleanup job invocations.

Changes

Modal Command Flag Updates in CI/CD Workflows

Layer / File(s) Summary
Nightly workflow Modal command updates
.github/workflows/tests-nightly.yml
Docker e2e and multigpu test jobs updated to use modal run -m for module invocation.
Main test workflow Modal command updates
.github/workflows/tests.yml
First e2e, main docker-e2e, and cleanup jobs updated to use modal run -m for module invocation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • axolotl-ai-cloud/axolotl#2929: Both PRs modify the Modal-based nightly e2e workflow to run the same cicd.multigpu job from .github/workflows/tests-nightly.yml with updates to the modal run invocation.

Suggested reviewers

  • djsaunde
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating Modal commands to use explicit module flags to address future deprecation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch modal-run-module-deprecation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@winglian winglian force-pushed the modal-run-module-deprecation branch from 746faa3 to 5cdfb47 Compare May 26, 2026 13:18
@winglian winglian added the scheduled_release This PR is slated for the upcoming release label May 26, 2026
@winglian winglian merged commit 135c4ee into main May 28, 2026
23 of 25 checks passed
@winglian winglian deleted the modal-run-module-deprecation branch May 28, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scheduled_release This PR is slated for the upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant