Skip to content

support for vllm 0.19.1#3613

Closed
winglian wants to merge 2 commits into
mainfrom
vllm-0191
Closed

support for vllm 0.19.1#3613
winglian wants to merge 2 commits into
mainfrom
vllm-0191

Conversation

@winglian

@winglian winglian commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated a core dependency to include patch-level improvements and stability enhancements.

@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 472b2622-a82a-416a-a0ea-98ff6f00dfed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated the minimum vllm dependency version from 0.19.0 to 0.19.1 for the torch>=2.10 code path in setup.py. This is a patch-level version constraint adjustment with no changes to dependency logic or control flow.

Changes

Cohort / File(s) Summary
Dependency version bump
setup.py
Updated extras_require_map["vllm"] version constraint from vllm>=0.19.0 to vllm>=0.19.1 for the (torch>=2.10) branch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • salmanmohammadi
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly reflects the main change: updating vllm dependency to version 0.19.1 in setup.py.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vllm-0191

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Apr 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@winglian

Copy link
Copy Markdown
Collaborator Author

shouldn't be needed now that we have it >= using uv

@winglian winglian closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant