Add uninstall command to cut_cross_entropy import message#3583
Conversation
📝 WalkthroughWalkthroughThis PR updates the cut-cross-entropy integration's installation message to include an explicit Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/axolotl/integrations/cut_cross_entropy/__init__.py (1)
36-39: Keep install remediation text consistent withscripts/cutcrossentropy_install.py.Line 38 now hardcodes an unconditional uninstall command, while
scripts/cutcrossentropy_install.py:21-32builds this command conditionally (and can include auvprefix). Consider sourcing the message from the same logic (or explicitly pointing users to the script output) to avoid conflicting troubleshooting instructions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/axolotl/integrations/cut_cross_entropy/__init__.py` around lines 36 - 39, The _CCE_INSTALL_MESSAGE constant currently hardcodes an unconditional uninstall command that conflicts with the conditional command built in scripts/cutcrossentropy_install.py; update the code so _CCE_INSTALL_MESSAGE is generated from the same logic (or simply point users to run the install script) instead of hardcoding the uninstall. Locate the _CCE_INSTALL_MESSAGE symbol in src/axolotl/integrations/cut_cross_entropy/__init__.py and either (A) import or call the installer message/builder from scripts/cutcrossentropy_install.py to produce the exact command (including optional "uv" prefix and conditional uninstall), or (B) replace the constant string with a short directive that tells users to run scripts/cutcrossentropy_install.py for the correct, environment-aware install command; ensure the final text no longer contains a conflicting hardcoded uninstall instruction.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/axolotl/integrations/cut_cross_entropy/__init__.py`:
- Around line 36-39: The _CCE_INSTALL_MESSAGE constant currently hardcodes an
unconditional uninstall command that conflicts with the conditional command
built in scripts/cutcrossentropy_install.py; update the code so
_CCE_INSTALL_MESSAGE is generated from the same logic (or simply point users to
run the install script) instead of hardcoding the uninstall. Locate the
_CCE_INSTALL_MESSAGE symbol in
src/axolotl/integrations/cut_cross_entropy/__init__.py and either (A) import or
call the installer message/builder from scripts/cutcrossentropy_install.py to
produce the exact command (including optional "uv" prefix and conditional
uninstall), or (B) replace the constant string with a short directive that tells
users to run scripts/cutcrossentropy_install.py for the correct,
environment-aware install command; ensure the final text no longer contains a
conflicting hardcoded uninstall instruction.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 19c9ff94-b13c-491a-a9c6-293d106c3639
📒 Files selected for processing (1)
src/axolotl/integrations/cut_cross_entropy/__init__.py
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Adds the uninstall command to the
cut_cross_entropyimport/install message.Motivation and Context
I was following the error message's install instructions, and it was not installing a newer version. I think it would be helpful to update this message with the uninstall part. See #3530 (comment)
How has this been tested?
Has not been tested.
AI Usage Disclaimer
No
Summary by CodeRabbit