Skip to content

Add uninstall command to cut_cross_entropy import message#3583

Merged
winglian merged 1 commit into
axolotl-ai-cloud:mainfrom
floaty3:patch-1
Apr 10, 2026
Merged

Add uninstall command to cut_cross_entropy import message#3583
winglian merged 1 commit into
axolotl-ai-cloud:mainfrom
floaty3:patch-1

Conversation

@floaty3

@floaty3 floaty3 commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the uninstall command to the cut_cross_entropy import/install message.

Motivation and Context

I was following the error message's install instructions, and it was not installing a newer version. I think it would be helpful to update this message with the uninstall part. See #3530 (comment)

How has this been tested?

Has not been tested.

AI Usage Disclaimer

No

Summary by CodeRabbit

  • Chores
    • Updated installation instructions to provide clearer guidance for dependency setup and reinstallation.

@coderabbitai

coderabbitai Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates the cut-cross-entropy integration's installation message to include an explicit pip uninstall -y cut-cross-entropy step before reinstalling the Axolotl fork from the specified git commit.

Changes

Cohort / File(s) Summary
Installation Message Update
src/axolotl/integrations/cut_cross_entropy/__init__.py
Added explicit pip uninstall -y cut-cross-entropy step to _CCE_INSTALL_MESSAGE before reinstalling the Axolotl fork from git.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • winglian
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an uninstall command to the cut_cross_entropy import message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/axolotl/integrations/cut_cross_entropy/__init__.py (1)

36-39: Keep install remediation text consistent with scripts/cutcrossentropy_install.py.

Line 38 now hardcodes an unconditional uninstall command, while scripts/cutcrossentropy_install.py:21-32 builds this command conditionally (and can include a uv prefix). Consider sourcing the message from the same logic (or explicitly pointing users to the script output) to avoid conflicting troubleshooting instructions.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/axolotl/integrations/cut_cross_entropy/__init__.py` around lines 36 - 39,
The _CCE_INSTALL_MESSAGE constant currently hardcodes an unconditional uninstall
command that conflicts with the conditional command built in
scripts/cutcrossentropy_install.py; update the code so _CCE_INSTALL_MESSAGE is
generated from the same logic (or simply point users to run the install script)
instead of hardcoding the uninstall. Locate the _CCE_INSTALL_MESSAGE symbol in
src/axolotl/integrations/cut_cross_entropy/__init__.py and either (A) import or
call the installer message/builder from scripts/cutcrossentropy_install.py to
produce the exact command (including optional "uv" prefix and conditional
uninstall), or (B) replace the constant string with a short directive that tells
users to run scripts/cutcrossentropy_install.py for the correct,
environment-aware install command; ensure the final text no longer contains a
conflicting hardcoded uninstall instruction.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/axolotl/integrations/cut_cross_entropy/__init__.py`:
- Around line 36-39: The _CCE_INSTALL_MESSAGE constant currently hardcodes an
unconditional uninstall command that conflicts with the conditional command
built in scripts/cutcrossentropy_install.py; update the code so
_CCE_INSTALL_MESSAGE is generated from the same logic (or simply point users to
run the install script) instead of hardcoding the uninstall. Locate the
_CCE_INSTALL_MESSAGE symbol in
src/axolotl/integrations/cut_cross_entropy/__init__.py and either (A) import or
call the installer message/builder from scripts/cutcrossentropy_install.py to
produce the exact command (including optional "uv" prefix and conditional
uninstall), or (B) replace the constant string with a short directive that tells
users to run scripts/cutcrossentropy_install.py for the correct,
environment-aware install command; ensure the final text no longer contains a
conflicting hardcoded uninstall instruction.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 19c9ff94-b13c-491a-a9c6-293d106c3639

📥 Commits

Reviewing files that changed from the base of the PR and between 7c56809 and d650d2d.

📒 Files selected for processing (1)
  • src/axolotl/integrations/cut_cross_entropy/__init__.py

@codecov

codecov Bot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@winglian winglian added the scheduled_release This PR is slated for the upcoming release label Apr 10, 2026
@winglian winglian merged commit 4dfa0a5 into axolotl-ai-cloud:main Apr 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scheduled_release This PR is slated for the upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants