Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): do not check player count during server start-up on Discord messages (fixes #84) #91

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

axieum
Copy link
Owner

@axieum axieum commented Jul 28, 2023

Fixes #84

@axieum axieum added the bug Something isn't working label Jul 28, 2023
@axieum axieum self-assigned this Jul 28, 2023
@github-actions github-actions bot added the minecord-chat Improvements or additions to the chat module label Jul 28, 2023
@axieum axieum merged commit 8cddbeb into main Jul 28, 2023
@axieum axieum deleted the fix/84-player-count-during-server-startup branch July 28, 2023 11:35
axieum added a commit that referenced this pull request Jul 28, 2023
axieum added a commit that referenced this pull request Oct 19, 2023
fix(chat): do not check player count during server start-up on Discord messages (fixes #84) (#91)
  (cherry picked from commit 8cddbeb)

refactor: defer config loading and reloading (#92)
  (cherry picked from commit e252ddb)

fix(cmds): option choices were incorrectly serializing to disk (fixes #83) (#90)
  This was caused by it being deserialized as JsonPrimitive, and then this object being serialized back to disk.
  (cherry picked from commit 70574c4)

chore(deps): update dependency JDA to v5.0.0-beta.15
chore(deps): update dependency fabric-api to v0.87.1+1.19.4
chore(deps): update dependency fabric-loader to v0.14.23
build(deps): update dependency checkstyle to v10.12.4
build(deps): update dependency fabric-loom to v1.4-SNAPSHOT
build(deps): upgrade gradle wrapper to v8.4
build(deps): update dependency junit to v5.10.0
build(deps): update dependency minotaur to v2.8.4
build(deps): update dependency shadow to v8.1.1
build(deps): update dependency yarn to v1.19.4+build.2

refactor: tidy up mixins
axieum added a commit that referenced this pull request Oct 19, 2023
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minecord-chat Improvements or additions to the chat module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warns of access to PlayerManager#getCurrentPlayerCount() during server start-up on Discord message
1 participant