Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(minecord-api): escape special regex characters in StringTemplate #65

Merged
merged 1 commit into from
Oct 1, 2022
Merged

fix(minecord-api): escape special regex characters in StringTemplate #65

merged 1 commit into from
Oct 1, 2022

Conversation

Kit-p
Copy link
Contributor

@Kit-p Kit-p commented Oct 1, 2022

As title. I also added one unit test for this.
Feedback is welcome!

Closes #61.

@github-actions github-actions bot added the minecord-api Improvements or additions to the api module label Oct 1, 2022
@axieum
Copy link
Owner

axieum commented Oct 1, 2022

Wonderful, and thanks so much for the test case! ✌️

@axieum axieum merged commit 4553977 into axieum:main Oct 1, 2022
@github-actions github-actions bot mentioned this pull request Oct 1, 2022
Merged
@Kit-p Kit-p deleted the fix/escape-string-in-template branch October 1, 2022 13:21
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axieum axieum axieum approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted minecord-api Improvements or additions to the api module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StringTemplate does not replace variables with special regex characters
2 participants
@Kit-p @axieum