Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work with translateable text #45

Closed
2 tasks done
Eatham532 opened this issue Jul 3, 2022 · 1 comment · Fixed by #48 or #49
Closed
2 tasks done

Work with translateable text #45

Eatham532 opened this issue Jul 3, 2022 · 1 comment · Fixed by #48 or #49
Labels
bug Something isn't working minecord-chat Improvements or additions to the chat module

Comments

@Eatham532
Copy link

Eatham532 commented Jul 3, 2022 •
edited
Loading

Is your feature request related to a problem?

The most obviously recognized example is when you complete an advancement that other mods add.

Screenshot_20220703-152213_Discord

I am sure that there are other things that use the same thing.

Describe the solution you'd like.

Use the translateable text in Discord.

Describe alternatives you've considered.

Nothing.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported mod version.

Other

No response
@axieum axieum added bug Something isn't working minecord-chat Improvements or additions to the chat module labels Jul 3, 2022
@Eatham532
Copy link
Author

I am sure that there are other things that use the same thing.

Oh Yeh, Death messages. died by entity:entity_name

axieum added a commit that referenced this issue Aug 5, 2022
@axieum
feat(api): add 'i18n' config for translations
8730615 
fix: modded translation keys should be resolved (fixes #45)
  this change will load all modded translation files at startup

refactor(chat): move world names option to the `api` module
@axieum axieum mentioned this issue Aug 5, 2022
Merged
@axieum axieum closed this as completed in #48 Aug 5, 2022
axieum added a commit that referenced this issue Aug 5, 2022
@axieum
feat(api): add 'i18n' config for translations (#48)
64b95c0 
fix: modded translation keys should be resolved (fixes #45)
  this change will load all modded translation files at startup

refactor(chat): move world names option to the `api` module
@github-actions github-actions bot mentioned this issue Aug 5, 2022
Merged
This was referenced Oct 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working minecord-chat Improvements or additions to the chat module
Projects
None yet
Milestone
No milestone
2 participants
@axieum @Eatham532