feat: support events with the same topic from different contracts #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNK90
approved these changes
Oct 16, 2023
|
so the idea is we will use the struct containing topic and address as a key for mapping for handling this logic. |
huyngopt1994
approved these changes
Oct 16, 2023
Currently, 2 events with the same topic but from different contracts are not handled correctly, the first register handler callback is called for both events. This commit makes the lookup key contains the both topic and contract address to correctly find the handler callback for the event.
minh-bq
force-pushed
the
feat/support-same-event-topic
branch
from
fae6349
to
fc02e35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, 2 events with the same topic but from different contracts are not handled correctly, the first register handler callback is called for both events. This commit makes the lookup key contains the both topic and contract address to correctly find the handler callback for the event.