optimize pool performance #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
reviewed
Dec 22, 2022
| @@ -109,8 +113,14 @@ func (p *Pool) startWorker(w Worker) { | |||
| if job == nil { | |||
| continue | |||
| } | |||
| if p.isClosed.Load().(bool) { | |||
| // update job to db | |||
| if err := job.Update(stores.STATUS_PENDING); err != nil { | |||
There was a problem hiding this comment.
The update queries for job with id in DB and update the status, so if we don't have that job in DB, this doesn't do anything?
There was a problem hiding this comment.
It is basically rely on the implementation of the job (implementation of the JobHandler). In this case, update acting as inserting
linh-1
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize pool performance by stop storing pending and done jobs to db
benchmark results with BenchmarkPool-16 and pool size = 8196:
| data size | solve time (ms) |
| 10000 | 194 |
| 100000 | 1565 |
| 1000000 | 11531 |
| 10000000 | 102254 |