Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separate pool and worker into struct to make them reusable #23

Merged
merged 5 commits into from
Nov 22, 2022
Merged

feat: separate pool and worker into struct to make them reusable #23

merged 5 commits into from
Nov 22, 2022

Conversation

DNK90
Copy link
Contributor

@DNK90 DNK90 commented Nov 20, 2022 •
edited
Loading

Reason

The current worker-pool model in this project is working well and I would like to reuse this in other projects without copying code.

What Changed:

  • Separate job and worker handler out of controller and name it as Pool
  • Make an interface called Worker while the old Worker has been changed into BridgeWorker which implements Worker

Tested on:

  • contract-indexers

@DNK90 DNK90 merged commit b5205fd into master Nov 22, 2022
@DNK90 DNK90 deleted the feat/reusable_worker_pool branch December 2, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minh-bq minh-bq minh-bq approved these changes

@ssscrom ssscrom Awaiting requested review from ssscrom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DNK90 @minh-bq