feat: upgrade soroban-sdk version to v21.7.6
#50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 99.11% 99.08% -0.04%
==========================================
Files 28 28
Lines 2953 2935 -18
==========================================
- Hits 2927 2908 -19
- Misses 26 27 +1 ☔ View full report in Codecov by Sentry. |
ahramy
approved these changes
Oct 30, 2024
hydrobeam
changed the title
soroban-sdk version to v21.7.6
milapsheth
approved these changes
Oct 30, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AXE-6310
Motivation
We are currently on
soroban-sdk = { version = "21.0.1-preview.3" }, which is outdated and has some issues with future rust versions (tests would always abort, fixed by stellar/rs-soroban-sdk#1333). Was told that sdk versions under the same major version guarantee no breaking changes and that the software-versions page is incorrectly claiming that mainnet is running the preview version.We don't need to always be on the latest version, but staying on a preview version doesn't seem ideal.
Summary
soroban_sdkversion to21.7.6, the latest one at the time of writingregister_stellar_asset_contract->register_stellar_asset_contract_v2)