Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaced attributes aren't updated incrementally #416

Closed
1 of 2 tasks
AndyOGo opened this issue Apr 30, 2018 · 1 comment · Fixed by #411
Closed
1 of 2 tasks

Namespaced attributes aren't updated incrementally #416

AndyOGo opened this issue Apr 30, 2018 · 1 comment · Fixed by #411
Assignees
Labels

Comments

@AndyOGo
Copy link

AndyOGo commented Apr 30, 2018

Are you reporting a bug or a feature?

  • Bug
  • Feature

Expected Behavior

All attributes including namespaced attributes should update on incremental rendering.

Actual Behavior

Steps to Reproduce the Problem

Namespaced attributes do not update.

  1. Open Firefox
  2. Go to https://axa-ch.github.io/patterns-library/atoms.html#a-icon

Chrome (Using new SVG <use href/>)
incremental-icon-chrome

Firefox (Using old SVG <use xlink:href/>)
incremental-icon-firefox-stops

Specifications

@AndyOGo
Copy link
Author

AndyOGo commented Apr 30, 2018

I implemented our own DOM morphing function.
So this is obsolete, though we could consider to publish it as it's own module...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants