Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first class props #39

Closed
3 tasks
AndyOGo opened this issue Dec 6, 2017 · 1 comment
Closed
3 tasks

first class props #39

AndyOGo opened this issue Dec 6, 2017 · 1 comment
Assignees
@LucaMele @AndyOGo @TheDadi
Labels
Enhancement Help wanted
Milestone
React Integration

Comments

@AndyOGo
Copy link

AndyOGo commented Dec 6, 2017 •
edited
Loading

How do we support properties other than string?

Requirements:

  • Data down, actions up
  • support prop types of Number, String, Boolean, Object, Array Null
  • Function as property

Note:
We already parse the given property string with JSON.parse(). This way we can support true, false, 1234, 'string', [], {}, null

Nice Reads:
@davidknezic davidknezic removed their assignment Dec 7, 2017
@AndyOGo AndyOGo mentioned this issue Jan 10, 2018
Closed
This was referenced Mar 9, 2018
Closed
Closed
@AndyOGo AndyOGo mentioned this issue Mar 21, 2018
Merged
10 tasks
@AndyOGo AndyOGo added this to the React Integration milestone Apr 17, 2018
@LucaMele
Copy link
Contributor

closing as new plib version is live. If issue is with v2 still relevant, please re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucaMele LucaMele

@AndyOGo AndyOGo

@TheDadi TheDadi

Labels
Enhancement Help wanted
Projects
None yet
Milestone
React Integration
Development

No branches or pull requests
4 participants
@davidknezic @LucaMele @AndyOGo @TheDadi