Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore: Read/write operations may not be thread safe #602

Closed
ecpullen opened this issue Apr 4, 2023 · 1 comment
Closed

Datastore: Read/write operations may not be thread safe #602

ecpullen opened this issue Apr 4, 2023 · 1 comment

Comments

@ecpullen
Copy link
Contributor

ecpullen commented Apr 4, 2023

The datastore uses a RwLock to manage reads and writes; however, the RwLock___Guard is dropped when .path() is called which will unlock the file.
@webern webern mentioned this issue Apr 21, 2023
Merged
@phu-cinemo phu-cinemo mentioned this issue Sep 28, 2023
Merged
@webern
Copy link
Contributor

webern commented Nov 3, 2023

This is fixed in #687! Closing!

@webern webern closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webern @ecpullen