Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe RegistryHost configuration types #944

Open
Tracked by #904
turan18 opened this issue Nov 15, 2023 · 0 comments
Open
Tracked by #904

Dedupe RegistryHost configuration types #944

turan18 opened this issue Nov 15, 2023 · 0 comments

Comments

@turan18
Copy link
Contributor

turan18 commented Nov 15, 2023

Description

Right now, we have two separate constructs in our config for providing registry specific configurations: ResolverConfig and Registry. The Registry config struct has been ported over from containerd/CRI. Containerd plans to move away from defining registry configurations directly in the config.toml and instead have users create host configuration files separately and provide the path to those configurations via the ConfigPath field. We should figure out a way to de-duplicate these constructs so that we have a centralized way of setting registry configurations.

Steps to reproduce the bug

No response

Describe the results you expected

  1. (Preferred - Backwards Incompatible) Remove the CRI Registry struct and all other containerd specific fields from ResolverConfig and replace it with a ConfigPath field. Rename ResolverConfig to RegistryConfig.

  2. Same as 1, but keep name as is ResolverConfig.

  3. Remove our Registry config, import the Registry config type from containerd and merge it with ResolverConfig.

Host information

  1. OS:
  2. Snapshotter Version:
  3. Containerd Version:

Any additional context or information about the bug

No response

@turan18 turan18 added the bug Something isn't working label Nov 15, 2023
@turan18 turan18 changed the title Dedup RegistryHosts configuration types Dedup RegistryHost configuration types Nov 15, 2023
@turan18 turan18 changed the title Dedup RegistryHost configuration types Dedupe RegistryHost configuration types Jan 16, 2024
@turan18 turan18 removed the bug Something isn't working label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants