Clarify request test host settings #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
approved these changes
Oct 22, 2021
mtdowling
reviewed
Oct 22, 2021
| @@ -106,19 +106,23 @@ that support the following members: | |||
| the query string (for example, "/foo/bar"). | |||
| * - host | |||
| - ``string`` | |||
| - The host / endpoint provided to the client (for example, "example.com"). | |||
| - The host or endpoint provided as input to the client (for example, | |||
There was a problem hiding this comment.
What about the server? Is this client only? Is the delta between host and resolvedHost ignored by servers implementing protocol tests?
| ``host`` MAY contain a path to indicate a base path from which each | ||
| operation in the service is appended to. For example, given a ``host`` | ||
| of ``example.com/foo/bar`` and an operation path of ``/MyOperation``, | ||
| the resolved host of the operation is ``example.com`` and the resolved | ||
| path is ``/foo/bar/MyOperation``. | ||
| * - resolvedHost | ||
| - ``string`` | ||
| - The host / endpoint that the client should send to, not including the | ||
| path or scheme (for example, "prefix.example.com"). | ||
| - The expected host that the client must send to, not including the path |
There was a problem hiding this comment.
Is this what goes in the Host header, which means server implementations would look at Host, right?
kstich
force-pushed
the
update_request_test_host_docs
branch
from
f187e93 to
ae3e2e1
Compare
mtdowling
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.