Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning when PATCH is idempotent #867

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

kstich
Copy link
Contributor

@kstich kstich commented Jul 16, 2021

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

https://datatracker.ietf.org/doc/html/rfc5789#section-2

PATCH is neither safe nor idempotent as defined by [RFC2616], Section
9.1.

A PATCH request can be issued in such a way as to be idempotent,
which also helps prevent bad outcomes from collisions between two
PATCH requests on the same resource in a similar time frame.
Collisions from multiple PATCH requests may be more dangerous than
PUT collisions because some patch formats need to operate from a
known base-point or else they will corrupt the resource. Clients
using this kind of patch application SHOULD use a conditional request
such that the request will fail if the resource has been updated
since the client last accessed the resource. For example, the client
can use a strong ETag [RFC2616] in an If-Match header on the PATCH
request.

@kstich kstich merged commit ae3af5e into main Jul 19, 2021
@mtdowling mtdowling deleted the remove_patch_idempotent_warning branch September 21, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants