S3 basic endpoint customizations #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested changes
Feb 5, 2021
| S3 Bucket Addressing | ||
| ==================== | ||
|
|
||
| Clients for Amazon S3 SHOULD expose multiple levels of configuration for bucket |
There was a problem hiding this comment.
We should move some of this language out to a general thing describing the config. Not really important for now though
| /// Controls the S3 addressing bucket style. | ||
| @enum([ | ||
| { | ||
| value: "default", |
There was a problem hiding this comment.
this should be "auto". See: https://docs.aws.amazon.com/credref/latest/refdocs/setting-s3-addressing_style.html
| name: "PATH", | ||
| }, | ||
| { | ||
| value: "virtual-host", |
There was a problem hiding this comment.
this should be "virtual"
This commit updates the S3 configuration to model virtual-hosting. It adds test cases and documentation for a subset of the bucket addressing methods: virtual hosts, path-style, dual-stack, and transfer acceleration.
kstich
force-pushed
the
s3_basic_endpoint_customizations
branch
from
58f2ef3 to
b958172
Compare
JordonPhillips
approved these changes
Feb 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add start of S3 customizations
This commit updates the S3 configuration to model virtual-hosting.
It adds test cases and documentation for a subset of the bucket
addressing methods: virtual hosts, path-style, dual-stack, and
transfer acceleration.
Add minimal S3 model for customization tests
Remove outdated test files
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.