Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document aws json rpc protocols #698

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

JordonPhillips
Copy link
Contributor

This fleshes out the documentation for the awsJson1_0 protocol.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@JordonPhillips JordonPhillips requested a review from kstich February 1, 2021 16:22
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
docs/source/1.0/spec/aws/aws-json-1_0-protocol.rst Outdated Show resolved Hide resolved
@JordonPhillips JordonPhillips requested a review from kstich February 1, 2021 20:36
@JordonPhillips JordonPhillips changed the title Document awsJson1_0 protocol Document aws json rpc protocols Feb 1, 2021
@JordonPhillips
Copy link
Contributor Author

Updated to also include awsJson1_1 using a template with substitutions to avoid duplicating text

This adds documentation for awsJson1_1 by abstracting out the docs
for awsJson1_0 and including substitutions for the small differences.
@JordonPhillips JordonPhillips merged commit 73ed360 into smithy-lang:main Feb 1, 2021
@kstich kstich mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants