-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document aws json rpc protocols #698
Merged
JordonPhillips
merged 2 commits into
smithy-lang:main
from
JordonPhillips:document-json-rpc
Feb 1, 2021
Merged
Document aws json rpc protocols #698
JordonPhillips
merged 2 commits into
smithy-lang:main
from
JordonPhillips:document-json-rpc
Feb 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Feb 1, 2021
kstich
reviewed
Feb 1, 2021
JordonPhillips
force-pushed
the
document-json-rpc
branch
from
February 1, 2021 20:36
f8196b9
to
8c40793
Compare
JordonPhillips
changed the title
Document awsJson1_0 protocol
Document aws json rpc protocols
Feb 1, 2021
JordonPhillips
force-pushed
the
document-json-rpc
branch
from
February 1, 2021 21:50
f28a5fd
to
de52770
Compare
Updated to also include awsJson1_1 using a template with substitutions to avoid duplicating text |
kstich
requested changes
Feb 1, 2021
JordonPhillips
force-pushed
the
document-json-rpc
branch
from
February 1, 2021 22:52
de52770
to
6c6d6c0
Compare
This adds documentation for awsJson1_1 by abstracting out the docs for awsJson1_0 and including substitutions for the small differences.
JordonPhillips
force-pushed
the
document-json-rpc
branch
from
February 1, 2021 22:53
6c6d6c0
to
07594f3
Compare
kstich
approved these changes
Feb 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fleshes out the documentation for the
awsJson1_0
protocol.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.