[WIP] Add support for CORS to API Gateway HTTP APIs #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support for adding CORS REST API headers is now in its own mapper class to better distinguish between the AddIntegrations mapper that is applied to every type of API Gateway service, and our support for CORS in REST APIs which is different than CORS in HTTP APIs.
mtdowling
force-pushed
the
http-api-cors-apig
branch
from
77deaac to
8e39a33
Compare
|
(rebased) |
srchase
approved these changes
Feb 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR to add support for CORS to API Gateway HTTP APIs. It still needs to be integration tested with an actual API Gateway API.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.