Add javadoc example and unit test for composing set via CodeWriter.on… #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Section() and inline section notation.
mtdowling
approved these changes
Oct 31, 2020
mtdowling
requested changes
Oct 31, 2020
|
|
||
| writer.write("[${L@testSection}]", ""); | ||
|
|
||
| assertThat(writer.toString(), equalTo("[1, 2, 3]")); |
There was a problem hiding this comment.
Oh, looks like this needs either a trailing newline, or you need to disable newlines in the writer
There was a problem hiding this comment.
I've pushed up a fix. I also moved this test to smithy-utils.
mtdowling
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Section() and inline section notation.
Issue #, if available: N/A
Based on slack discussion, added javadoc to demonstrate generating a list using inline sections with an accompanying unit test. Happy to remove the unit test of deemed redundant.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.