Optimize reverse neighbors for memory #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method previously needed lots of intermediate representations stored in memory to create a Map<ShapeId, List<RelationShip>> that contains only unique relationships. It was done using Stream, distinct, and groupingBy. However, when trying to load ridiculously large models, that approach consume tons of heap. This approach allocates as little as possible (I think), but does require creating an ArrayList copy of a Set each time neighbors are returned.
srchase
suggested changes
Oct 5, 2020
smithy-model/src/main/java/software/amazon/smithy/model/neighbor/NeighborProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chase Coalwell <[email protected]>
srchase
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method previously needed lots of intermediate representations
stored in memory to create a Map<ShapeId, List> that
contains only unique relationships. It was done using Stream,
distinct, and groupingBy. However, when trying to load ridiculously
large models, that approach consume tons of heap. This approach
allocates as little as possible (I think), but does require creating
an ArrayList copy of a Set each time neighbors are returned.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.