Add aws.cloudformation traits #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
force-pushed
the
add_cloudformation_traits
branch
from
09e61bc to
dc5a8a7
Compare
mtdowling
requested changes
Sep 29, 2020
|
I just made it through the spec, but can circle back for the implementation once the spec is nailed down. |
kstich
force-pushed
the
add_cloudformation_traits
branch
from
dc5a8a7 to
ba01567
Compare
mtdowling
requested changes
Oct 21, 2020
smithy-aws-cloudformation-traits/src/main/resources/META-INF/smithy/aws.cloudformation.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-cloudformation-traits/src/main/resources/META-INF/smithy/aws.cloudformation.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-cloudformation-traits/src/main/resources/META-INF/smithy/aws.cloudformation.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-cloudformation-traits/src/main/resources/META-INF/smithy/aws.cloudformation.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-cloudformation-traits/src/main/resources/META-INF/smithy/aws.cloudformation.smithy
Show resolved
Hide resolved
kstich
force-pushed
the
add_cloudformation_traits
branch
from
ba01567 to
7ef7419
Compare
mtdowling
requested changes
Oct 29, 2020
...ation-traits/src/main/java/software/amazon/smithy/aws/cloudformation/traits/CfnResource.java
Show resolved
Hide resolved
...ation-traits/src/main/java/software/amazon/smithy/aws/cloudformation/traits/CfnResource.java
Outdated
Show resolved
Hide resolved
...ation-traits/src/main/java/software/amazon/smithy/aws/cloudformation/traits/CfnResource.java
Show resolved
Hide resolved
kstich
force-pushed
the
add_cloudformation_traits
branch
from
7ef7419 to
ff3402b
Compare
mtdowling
approved these changes
Oct 30, 2020
This commit adds several traits in the aws.cloudformation namespace, contained in a new smithy-aws-cloudformation-traits package. These traits indicate CloudFormation resources and the additional metadata about their properties. A CfnResourceIndex is also included to make using this information more accessible and to handle derived property mutabilities.
kstich
force-pushed
the
add_cloudformation_traits
branch
from
ff3402b to
5bd9e9b
Compare
This commit introduces a new "cloudformation" build plugin that, given a model decorated with the aws.cloudformation traits, will generate CloudFormation Resource Schemas. This includes support for specifying the mutability of properties, their documentation, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds several traits in the
aws.cloudformationnamespace,contained in a new
smithy-aws-cloudformation-traitspackage. Thesetraits indicate CloudFormation resources and the additional metadata
about their properties. A
ResourceIndexis also included to make usingthis information more accessible and to handle derived property
mutabilities.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.