Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds restxml protocol test around xml preamble, CDATA, escaped characters #528

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Adds restxml protocol test around xml preamble, CDATA, escaped characters #528

merged 2 commits into from
Aug 17, 2020

Conversation

skotambkar
Copy link
Contributor

Description of changes:

  1. Adds few protocol test for rest xml deserializers to check behavior with xml preamble, comments, CDATA, white space, characters that need to be escaped are present in xml response body.
  2. Adds test cases for white space, character escaping when serializing into xml request body.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@JordonPhillips JordonPhillips merged commit b455770 into smithy-lang:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstich kstich kstich approved these changes

@JordonPhillips JordonPhillips JordonPhillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skotambkar @JordonPhillips @kstich