Disallow problematic identifiers #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Jul 16, 2020
smithy-model/src/main/java/software/amazon/smithy/model/shapes/ShapeId.java
Outdated
Show resolved
Hide resolved
These newly disallowed identifiers were never actually supported in practice and are problematic on multiple levels: 1. An identifier like `_` or `__` are bad names that don't help users understand an API. 2. Identifiers like `_` are problematic for languages like Rust that use this character for pattern matching.
mtdowling
force-pushed
the
update-shape-id-syntax
branch
from
b0f98d5 to
3ca1ce2
Compare
kstich
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These newly disallowed identifiers were never actually supported in
practice and are problematic on multiple levels:
_or__are bad names that don't help users understand an API._are problematic for languages like Rust that use this character for pattern matching.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.