Add support message templates in EmitEachSelector #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
emit-each-selector-templates
branch
2 times, most recently
from
507a7d1 to
7b6a77f
Compare
kstich
requested changes
Jun 16, 2020
smithy-utils/src/main/java/software/amazon/smithy/utils/SimpleParser.java
Outdated
Show resolved
Hide resolved
smithy-utils/src/main/java/software/amazon/smithy/utils/SimpleParser.java
Outdated
Show resolved
Hide resolved
mtdowling
force-pushed
the
emit-each-selector-templates
branch
from
7b6a77f to
09822e8
Compare
kstich
approved these changes
Jun 16, 2020
JordonPhillips
approved these changes
Jun 17, 2020
smithy-utils/src/main/java/software/amazon/smithy/utils/SimpleParser.java
Outdated
Show resolved
Hide resolved
This commit adds support for templated messages in the EmitEachSelector that are able to reference variables captured while shapes are matched. This allows for very rich and descriptive error messages that generally are as good as error messages in code-driven Smithy validators. In order to pull this, it required that attribute value selector context values could be parsed from a message template. Since context values are already parsed as part of parsing selectors, this motivated me to reuse the existing selector's parsing functionality. To do this, I created a SimpleParser abstraction that extracts out lots of the duplicate parsing code in Smithy into a single class. This allowed parsing of attributes to be shared, but it was also an opportunity to trim down duplicate code and reuse parsing logic across the IDL and selectors.
mtdowling
force-pushed
the
emit-each-selector-templates
branch
from
09822e8 to
d5b2f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for templated messages in the EmitEachSelector
that are able to reference variables captured while shapes are matched.
This allows for very rich and descriptive error messages that generally
do as good as error messages in code-driven Smithy validators.
In order to pull this, it required that attribute value selector context
values could be parsed from a message template. Since context values are
already parsed as part of parsing selectors, this motivated me to reuse
the existing selector's parsing functionality. To do this, I created a
SimpleParser abstraction that extracts out lots of the duplicate parsing
code in Smithy into a single class. This allowed parsing of attributes
to be shared, but it was also an opportunity to trim down duplicate code
and reuse parsing logic across the IDL and selectors.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.