Rewrite grammar and parser #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
May 12, 2020
...resources/software/amazon/smithy/model/loader/invalid/strings/invalod-unicode-escape2.smithy
Outdated
Show resolved
Hide resolved
...t/resources/software/amazon/smithy/model/loader/invalid/control-version-defined-twice.smithy
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlTextParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlShapeIdParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Show resolved
Hide resolved
mtdowling
force-pushed
the
rewrite-grammar-and-parser
branch
from
6533f90 to
2752061
Compare
mtdowling
force-pushed
the
rewrite-grammar-and-parser
branch
2 times, most recently
from
e6836f8 to
bec25c8
Compare
kstich
approved these changes
May 13, 2020
JordonPhillips
approved these changes
May 13, 2020
This commit is a complete rewrite of the Smithy IDL parser and grammar. It is intended to clear up the intention of how the IDL works in practice by making the grammar embed things like how control statements come before metadata, which come before namespace, etc.. It also clarifies how different node_value locations have different semantics (e.g., keys in objects are not resolved against keywords like true and do not perform relative shape ID resolution nor do they support text blocks). Many other fixes have been made to the grammar too, including specifying where whitespace is allowed and where line breaks are required. This makes the grammar more verbose but also more accurate and in line with what was already implemented. With these changes, control statement keyus, metadata keys, and object keys must now be quoted if they contain ".", "#", or "$". In practice, the model parser already enforced these constraints in some places.
mtdowling
force-pushed
the
rewrite-grammar-and-parser
branch
from
bec25c8 to
1e2a417
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a complete rewrite of the Smithy IDL parser and grammar.
It is intended to clear up the intention of how the IDL works in
practice by making the grammar embed things like how control statements
come before metadata, which come before namespace, etc.. It also
clarifies how different node_value locations have different semantics
(e.g., keys in objects are not resolved against keywords like
true and do not perform relative shape ID resolution nor do they support
text blocks). Many other fixes have been made to the grammar too,
including specifying where whitespace is allowed and where line breaks
are required. This makes the grammar more verbose but also more accurate
and in line with what was already implemented.
With these changes, control statement keyus, metadata keys, and object keys
must now be quoted if they contain ".", "#", or "$". In practice, the
model parser already enforced these constraints in some places.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.