[0.10] Add protocol and auth trait requirements #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
approved these changes
Feb 21, 2020
|
Should |
mtdowling
changed the title
Protocol traits now list the traits that protocol implementations must understand in order to successfully implement the protocol. This provides the ability to better ensure correctness of protocol implementations as protocols evolve.
mtdowling
force-pushed
the
protocol-trait-requirements
branch
from
b742a8f to
d3adc3a
Compare
mtdowling
changed the title
|
Sure. I updated the auth trait to also have a list of trait requirements. We discussed this and don't see it as a general abstraction at this point (like a new property of trait definitions). These requirements are really a function of serialization and deserialization specific traits, which is what auth and protocol traits are. |
kstich
requested changes
Feb 24, 2020
mtdowling
force-pushed
the
protocol-trait-requirements
branch
from
d3adc3a to
6e1274c
Compare
kstich
approved these changes
Feb 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol traits now list the traits that protocol implementations must
understand in order to successfully implement the protocol. This
provides the ability to better ensure correctness of protocol
implementations as protocols evolve.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.