Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty enum with non-empty mixins #1794

Merged
merged 1 commit into from
May 26, 2023

Conversation

AndrewFossAWS
Copy link
Contributor

Issue #, if available:
Customer tries to apply a non-empty enum mixin to an empty enum:

@mixin
enum EnumMixin {
    VALUE = "value"
}

enum EmptyEnum with [EnumMixin] {}

Smithy build fails with enum must have at least one entry. This was caused by mixin enum members not getting populated to the synthetic enum trait.

Description of changes:
Allow empty enum with non-empty mixins

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AndrewFossAWS AndrewFossAWS requested a review from a team as a code owner May 25, 2023 21:51
@AndrewFossAWS AndrewFossAWS merged commit c619a9a into smithy-lang:main May 26, 2023
@AndrewFossAWS AndrewFossAWS deleted the empty-enum branch September 21, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants