Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI install PowerShell instructions #1757

Merged
merged 1 commit into from
May 4, 2023

Conversation

normj
Copy link
Contributor

@normj normj commented Apr 28, 2023

Description of changes:
Reworked the scripts in the docs for installing the Smithy CLI.

  • Replaced wget with Invoke-WebRequest since wget is not a standard tool installed on Windows
  • Removed the usage of -and because it results in a confusing false being printed every time you run the scripts. Replaced with ; for running multiple commands.
  • Used the ` token to break up long lines to make it more readable
  • Replaced the mkdir with New-Item to follow the cmdlet pattern.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj normj requested a review from a team as a code owner April 28, 2023 22:01
@haydenbaker
Copy link
Contributor

Thanks for the changes! I'll go ahead and test these today, and we can get it merged.

@haydenbaker haydenbaker self-requested a review May 1, 2023 17:12
@haydenbaker haydenbaker force-pushed the fix-powershell-scripts branch from 72908b6 to fb515a9 Compare May 2, 2023 16:25
@haydenbaker
Copy link
Contributor

Made 1 small fix. Will approve and merge later today. Thank you!

@haydenbaker haydenbaker merged commit 7cd402b into smithy-lang:main May 4, 2023
syall pushed a commit to Xtansia/smithy that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants