Add requestCompression trait #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
requestCompression-trait
branch
2 times, most recently
from
31bba1d to
9e2fa64
Compare
syall
force-pushed
the
requestCompression-trait
branch
from
9e2fa64 to
34b44c0
Compare
hpmellema
reviewed
Apr 24, 2023
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Outdated
Show resolved
Hide resolved
sugmanue
reviewed
Apr 24, 2023
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/traits/RequestCompressionTraitTest.java
Outdated
Show resolved
Hide resolved
kstich
requested changes
Apr 24, 2023
smithy-model/src/main/java/software/amazon/smithy/model/traits/RequestCompressionTrait.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/traits/RequestCompressionTrait.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/RequestCompressionTraitValidator.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy
Show resolved
Hide resolved
syall
force-pushed
the
requestCompression-trait
branch
2 times, most recently
from
2068f33 to
108fb75
Compare
hpmellema
approved these changes
Apr 25, 2023
kstich
reviewed
Apr 25, 2023
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
requestCompression-trait
branch
from
108fb75 to
4bcaa50
Compare
AndrewFossAWS
approved these changes
Apr 25, 2023
sugmanue
approved these changes
Apr 25, 2023
sugmanue
reviewed
Apr 25, 2023
| Smithy clients MUST expose a setting ``REQUEST_MIN_COMPRESSION_SIZE_BYTES`` to | ||
| specify the minimum size in bytes that a request body should be to trigger | ||
| compression. The value MUST be a non-negative integer in the range ``0`` and | ||
| ``10485760`` inclusive, and defaults to ``10240`` bytes. If the value is outside |
There was a problem hiding this comment.
I personally feel that adding a clarifying note about why we choose 10240 will be worth. Otherwise this feels like a magic number.
kstich
approved these changes
Apr 25, 2023
added 2 commits
April 25, 2023 10:38
Add support for the `requestCompression` trait. Operations with the trait applied direct clients to compress requests sent to services and set the corresponding encoding in the ``Content-Encoding`` header.
Add the `requestCompression` trait specification under behavior traits, including client behavior, client implementation, and backward compatibility.
syall
force-pushed
the
requestCompression-trait
branch
2 times, most recently
from
9fe9c03 to
cf0539e
Compare
added 2 commits
April 25, 2023 11:01
Add protocol tests for the 6 AWS protocols: - `restJson1` - `awsJson1_0` - `awsJson1_1` - `restXml` - `awsQuery` - `ec2`
Add entry for Smithy LSP log.
syall
force-pushed
the
requestCompression-trait
branch
from
cf0539e to
f06d572
Compare
kstich
approved these changes
Apr 25, 2023
mtdowling
reviewed
Apr 25, 2023
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
This PR adds the
requestCompressiontrait which indicates whether an operation supports compressed requests from clients to services.Changes include:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.