Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: type correction in primitive root-level example #1687

Merged
merged 1 commit into from
Mar 18, 2023
Merged

docs: type correction in primitive root-level example #1687

merged 1 commit into from
Mar 18, 2023

Conversation

WarFox
Copy link
Contributor

@WarFox WarFox commented Mar 18, 2023

Description of changes:

Minor correction in an example provided in documentation for migration from Smithy v1 to v2

MyPrimitiveInteger was typed as boolean, it should be integer

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

MyPrimitiveInteger was typed as boolean, it should be integer
@WarFox WarFox requested a review from a team as a code owner March 18, 2023 12:12
Copy link
Member

@mtdowling mtdowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtdowling mtdowling merged commit 4e9d536 into smithy-lang:main Mar 18, 2023
@WarFox WarFox deleted the patch-1 branch March 18, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants