Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow core validation events to be suppressible #1646

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Feb 28, 2023

Previously, core validation events resulted in errors, which could not be suppressed.

Now, events from the TargetValidator can result in warnings, which could be suppressed.

This PR updates the ModelValidator to check core validation events for matching suppressions with tests covering both metadata suppressions and suppressions through the @suppress trait.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from a team as a code owner February 28, 2023 22:13
@srchase srchase force-pushed the suppress-core-events branch from 3b4bbd4 to 0edd005 Compare February 28, 2023 23:25
@srchase srchase merged commit f7f16f6 into smithy-lang:main Mar 1, 2023
@srchase srchase deleted the suppress-core-events branch March 1, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants