Clarify rules for escaping shapes bound to URIs #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the rules for escaping values of shapes bound to the HTTP URI according to the rules of RFC3986. The list of characters to escape was replaced with a list of safe characters. Initially that was created by subtracting the reserved characters in section 2.2 from the relevant valid characters defined in the productions for the particular binding locations, but those all ended up being equivalent to the unreserved characters production in section 2.3. closes smithy-lang#1011
srchase
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the rules for escaping values of shapes bound to the HTTP URI according to the rules of RFC3986. The list of characters to escape was replaced with a list of safe characters. Initially that was created by subtracting the reserved characters in section 2.2 from the relevant valid characters defined in the productions for the particular binding locations, but those all ended up being equivalent to the unreserved characters production in section 2.3.
closes #1011
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.