Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit serializing empty http-query lists #1629

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Feb 22, 2023

This PR adds a protocol test to clarify clients should omit empty lists when serializing a query string.

When serializing an empty string for param Foo, Foo= is serialized in the query string. An empty list for param Foo cannot also be serialized as Foo= as one might expect. Instead, it is omitted to clearly differentiate between an empty string, and an empty list.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from a team as a code owner February 22, 2023 23:40
@srchase srchase merged commit 57873f3 into smithy-lang:main Feb 22, 2023
@srchase srchase deleted the http-query-empty-lists branch February 22, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants