Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify handling of date-time offsets #1597

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 28, 2023

This PR clarifies the timestampFormat trait documentation concerning UTC offsets.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from a team as a code owner January 28, 2023 00:01
Copy link
Contributor

@gosar gosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we make the same change in the 1.0 specs?

@srchase srchase force-pushed the clarify-datetime-offset-parsing branch from 5d459e2 to 297c2c7 Compare January 30, 2023 14:51
@srchase
Copy link
Contributor Author

srchase commented Jan 30, 2023

Shouldn't we make the same change in the 1.0 specs?

Added in 297c2c7.

@srchase srchase force-pushed the clarify-datetime-offset-parsing branch from 297c2c7 to 9ebbb0e Compare January 30, 2023 23:25
@srchase srchase force-pushed the clarify-datetime-offset-parsing branch from 9ebbb0e to 94bfa9b Compare January 30, 2023 23:29
@srchase srchase changed the title Clarify client vs server handling of date-time offsets Clarify handling of date-time offsets Jan 30, 2023
@srchase srchase merged commit 32b111f into smithy-lang:main Feb 15, 2023
@srchase srchase deleted the clarify-datetime-offset-parsing branch February 15, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants