Ensure that AuthSchemes added to Endpoint builder retain parameter ordering #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
reviewed
Jan 25, 2023
| this.authSchemes.get().add(Pair.of(Identifier.of(scheme), | ||
| parameters.entrySet().stream() | ||
| .collect(Collectors.toMap(k -> Identifier.of(k.getKey()), Map.Entry::getValue)))); | ||
| Map<Identifier, Literal> transformedParameters = new LinkedHashMap<>(); |
There was a problem hiding this comment.
should we be sorting here? this relies on the incoming map being linked right? Or at least log a warning if the incoming map isn't linked?
There was a problem hiding this comment.
Yeah, it does rely on the incoming map being stable - and maybe the best approach here is to just sort all of these. My other thought was to provide AuthScheme builders that make building these property maps more fluid in the first place.
There was a problem hiding this comment.
yeah I think an auth scheme builder is probably a good idea—I think we ended up writing one in some of the downstream crates
… always maintain a stable order and not rely on input to be stable
rcoh
approved these changes
Jan 25, 2023
kstich
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Ensure that AuthSchemes added to Endpoint builder retain parameter ordering.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.