Warn when default used with union member target #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
reviewed
Sep 21, 2022
...re/amazon/smithy/model/errorfiles/validators/defaults/warn-when-union-targets-default.smithy
Show resolved
Hide resolved
This NOTE warning makes it clear to modelers that default values on the target shape of a union member are ignored.
mtdowling
force-pushed
the
warn-when-defaults-used-with-union-member-targets
branch
from
bbf5efc to
f1501a6
Compare
gosar
approved these changes
Sep 21, 2022
mtdowling
deleted the
warn-when-defaults-used-with-union-member-targets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This NOTE warning makes it clear to modelers that default values on the target shape of a union member are ignored.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.