Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore valid set->list type change in diff #1383

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

mtdowling
Copy link
Member

It isn't an error to migrate a set to a list with the uniqueItems
trait. This is a recommended change because sets are deprecated and
should not be implemented by any tooling.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

It isn't an error to migrate a set to a list with the uniqueItems
trait. This is a recommended change because sets are deprecated and
should not be implemented by any tooling.
@mtdowling mtdowling requested a review from a team as a code owner September 2, 2022 17:42
@mtdowling mtdowling merged commit 319389f into main Sep 2, 2022
@mtdowling mtdowling deleted the smithy-diff-ignore-set-to-list branch October 24, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants