Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing readonly traits on HTTP GET tests #1354

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Aug 17, 2022

Adds missing @readonly traits on HTTP GET protocol tests, eliminating the following warnings:

WARNING: aws.protocoltests.restjson#ResponseCodeRequired (HttpMethodSemantics)
   @ ~/smithy/smithy-aws-protocol-tests/model/restJson1/http-response-code.smithy
   |
 22 | @http(method: "GET", uri: "/responseCodeRequired", code: 200)
   | ^
   = This operation uses the `GET` method in the `http` trait, but is not marked with the readonly trait
WARNING: aws.protocoltests.restjson#ResponseCodeHttpFallback (HttpMethodSemantics)
   @ ~/smithy/smithy-aws-protocol-tests/model/restJson1/http-response-code.smithy
   |
 34 | @http(method: "GET", uri: "/responseCodeHttpFallback", code: 201)
   | ^
   = This operation uses the `GET` method in the `http` trait, but is not marked with the readonly trait

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from a team as a code owner August 17, 2022 19:06
@kstich kstich merged commit 237dbcb into smithy-lang:main Aug 17, 2022
@srchase srchase deleted the fix-readonly-warnings branch August 17, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants